Stop recommending node-builtins#4190
Merged
lukastaegert merged 2 commits intorollup:masterfrom Jul 25, 2021
Merged
Conversation
Contributor
Author
|
Aha! Forgot to update the tests... Sorry. Will do. |
Codecov Report
@@ Coverage Diff @@
## master #4190 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 202 202
Lines 7232 7232
Branches 2116 2116
=======================================
Hits 7112 7112
Misses 58 58
Partials 62 62
Continue to review full report at Codecov.
|
This was referenced Jul 24, 2021
Niek
approved these changes
Jul 24, 2021
Contributor
Author
|
Thanks @lukastaegert! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #2881
Description
I recently went on a wild goose chase trying to figure out the best solution in the current Rollup ecosystem for polyfilling Node builtins. Long story short, this repository https://github.com/snowpackjs/rollup-plugin-polyfill-node looks to be, by far, the best alternative to the currently recommended repository, which has not been maintained for 2 years. I personally migrated to this package and it appears to work extremely well.
Related threads: