Skip to content

[TASK] Add AfterFunctionLikeAnalysisEvent::getFunctionlikeStorage#7526

Merged
weirdan merged 1 commit intovimeo:masterfrom
ohader:event-naming
Jan 30, 2022
Merged

[TASK] Add AfterFunctionLikeAnalysisEvent::getFunctionlikeStorage#7526
weirdan merged 1 commit intovimeo:masterfrom
ohader:event-naming

Conversation

@ohader
Copy link
Copy Markdown
Contributor

@ohader ohader commented Jan 30, 2022 •
edited
Loading

AfterFunctionLikeAnalysisEvent's method getClasslikeStorage actually
returned the current FunctionLikeStorage. This change streamlines the
naming and adds corresponding getFunctionlikeStorage method.

Releases: 5.0

4.x deprecation: #7532

@orklah
Copy link
Copy Markdown
Collaborator

orklah commented Jan 30, 2022

Please commit the deprecation on 4.x and its removal in master

But sorry for the name, I believe it was a mistake I made 1 and a half year ago :(

@ohader
Copy link
Copy Markdown
Contributor Author

ohader commented Jan 30, 2022 •
edited
Loading

Please commit the deprecation on 4.x and its removal in master

Shall the 4.x change also include the new method? Thus, people already could switch to use the new method, even when still running a 4.x version. master branch would then really only contain the removal and the change to UPGRADING.md. Correct?

But sorry for the name, I believe it was a mistake I made 1 and a half year ago :(

Don't worry. I just was upgrading our code-base for Psalm v5 and stumbled over that @todo annotation in our code... 😃

@orklah
Copy link
Copy Markdown
Collaborator

orklah commented Jan 30, 2022

As long as you can add the full feature without BC break on 4.x, go for it yeah, then just remove the old on master

@ohader ohader mentioned this pull request Jan 30, 2022
Merged
@weirdan weirdan added the release:removed The PR will be included in 'Removed' section of the release notes label Jan 30, 2022
@weirdan weirdan merged commit e3050b1 into vimeo:master Jan 30, 2022
@weirdan
Copy link
Copy Markdown
Collaborator

weirdan commented Jan 30, 2022

Thanks!

@ohader ohader deleted the event-naming branch January 31, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

release:removed The PR will be included in 'Removed' section of the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ohader @orklah @weirdan