Conversation
|
I think v0.14 "master" is currently in |
Pointing at main now. I will delete the release/v0.14 branch I made. |
|
|
||
| if !map_keys_requests.is_empty() { | ||
| let forest_guard = self.forest.read().await; | ||
| let forest_guard = self.forest.read().instrument(tracing::Span::current()).await; |
There was a problem hiding this comment.
Why was this needed?
There was a problem hiding this comment.
To have a dedicated span and duration for reading this lock.
There was a problem hiding this comment.
I think @SantiagoPittella means that this should already be auto-instrumented by the #[instrument] on the function. If it wasn't then this is.. unexpected.
If you want a dedicated span then we should give this a new span, not re-use the current one.
There was a problem hiding this comment.
Sorry had meant to .instrument(tracing::info_span!("something")).
I think/hope we don't need instrument(tracing::Span::current()) on such futures to ensure they fall under the relevant span of the stack they are called from.
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left a couple of small comments inline.
Relates to #1920.