Open
Conversation
JereSalo
approved these changes
Apr 14, 2026
Collaborator
JereSalo
left a comment
There was a problem hiding this comment.
Left some tiny suggestions, the rest is perfect though.
sergerad
reviewed
Apr 15, 2026
Mirko-von-Leipzig
approved these changes
Apr 16, 2026
Collaborator
|
Makes me wonder if we shouldn't switch to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1931
When the Explorer or Faucet change their response format, the monitor now produce an error messages with the actual field that changed. The Explorer previously reported "missing field: block_number" when the field was present but had a different type. It now distinguishes between missing fields ("field 'block_number': not present in response") and type mismatches ("field 'block_number': expected u64-compatible value, got "abc""). Faucet deserialization errors now identify which endpoint failed.