This repository was archived by the owner on Jan 17, 2023. It is now read-only.
Closed
Conversation
added 3 commits
April 4, 2013 18:59
…convenience class method. This enables using the method with subclasses.
This is technically incorrect, as "image/jpg" is not a valid MIME type, but certain web servers return this type for JPEG images which causes AFImageRequestOperation to fail.
…ass method on OS X too.
Contributor
|
Thanks for submitting this pull request, @jam. You're absolutely correct to fix the use of an explicit class instead of As for adding the acceptable content type, there is a class method for just that purpose (which means that you didn't have to subclass to begin with): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a couple of issues I was having when using AFImageRequestOperation.
image/jpg. While technically incorrect, this caused the operation to fail, which isn't desirable behaviour. Unfortunately the server isn't one I control, otherwise I'd have made the change on the server side.AFImageRequestOperationto include the invalid type, I noticed thatimageRequestOperationWithRequest:imageProcessingBlock:success:failure:always returned AFImageRequestOperation instances, rather than instances of the current class (like the other request operation classes).