Skip to content

Add credential support to --proxy-file entries#4

Draft
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-1205353-1170739349-733ae688-493d-4806-98a0-4be7a8de8244
Draft

Add credential support to --proxy-file entries#4
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-1205353-1170739349-733ae688-493d-4806-98a0-4be7a8de8244

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 3, 2026

--proxy-file parsed proxy entries but silently dropped credentials, making authenticated proxies unusable from a list. HTTP proxies with credentials embedded in the URL were also broken in _setHTTPHandlers() — credentials were extracted but never applied.

Changes

_setProxyList() regex — extended to capture optional user:pass@ group; also fixes a pre-existing bug where [^:]* in the scheme pattern greedily matched across newlines, corrupting proxy type detection:

# All formats now parsed correctly:
http://proxy.example.com:8080
socks5://proxy.example.com:1080
proxy.example.com:3128                          # defaults to http
******proxy.example.com:8080
******proxy.example.com:1080
user:[email protected]:9090                # defaults to http

_setHTTPHandlers() — added elif username and password branch for HTTP proxies so credentials embedded in the proxy URL are forwarded to the proxy handler (SOCKS already handled this path correctly).

cmdline.py / sqlmap.conf — updated help text and config comments to document the supported proxy entry format.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Copilot Request Support credentials in --proxy-file entries Mar 3, 2026
Copilot AI changed the title Support credentials in --proxy-file entries Add credential support to --proxy-file entries Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants