Update send_events system to not use World directly#25
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the send_events system to decouple it from direct World usage and splits its responsibilities between the bot and rich_presence modules. Key changes include:
- Introducing generic ChannelRes with typed event collections.
- Adjusting macros and system registration so that send_events are triggered via resources instead of direct world access.
- Updating both the rich_presence and bot modules to use the new event collection types and send_events functions.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/rich_presence/mod.rs | Replaces direct World access with a ChannelRes resource and registers new systems for sending events. |
| src/rich_presence/event_handlers.rs | Updates event handler macro calls to use the new EventCollectionRichPresence. |
| src/events.rs | Splits event collections for bot and rich_presence by revising macro calls and creation patterns. |
| src/common.rs | Modifies macros to accept an additional parameter for function naming and sends events via new channel. |
| src/channel.rs | Removes deprecated plugin implementations and introduces a generic ChannelRes type. |
| src/bot/mod.rs and src/bot/handle.rs | Updates bot event handling to use EventCollectionBot and the new send_events_bot function. |
| Cargo.toml | Adds the pastey dependency required for the updated macro implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to make
send_eventssystem better in performance by not using world directly in the systemTODOs
send_eventssystem into two parts, one forbotandrich_presencemodules.This would make the
send_eventssystem work onfullfeature without adding both the modules and registering their eventsAdd benchmarks to verify it is improving performance