Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the codebase by removing legacy Rust version compatibility code. Since the pastey crate now only supports Rust versions >=1.54, the conditional compilation logic for older versions is no longer needed.
- Removes the entire
build.rsfile that was used to detect Rust version and set cfg flags - Moves imports from conditional compilation blocks to the top-level imports in
lib.rs - Removes the
no_literal_fromstrcfg check that was used for Rust <1.54 compatibility
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build.rs | Completely removed - was only needed for Rust <1.54 compatibility |
| src/lib.rs | Moved LexError, Literal, and FromStr imports to top-level and removed conditional compilation block |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13
This PR removes
build.rsas it was used to support rust version <1.54 by using cfg flags. It is not needed anymore because pastey crate only supports>=1.54rust versions