Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CI build failures for Rust 1.56.0 by updating dependency version constraints. Instead of constraining the glob dependency in the Cargo.toml file, the fix now explicitly pins compatible versions of multiple dependencies (serde_derive and proc-macro2 in addition to existing quote and glob pins) in the test script when running on Rust 1.56.0.
Key changes:
- Added version pinning for
serde_deriveandproc-macro2dependencies in the test script for Rust 1.56.0 compatibility - Removed the
globversion constraint and its accompanying comment from the Cargo.toml file
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test.sh | Added cargo update commands to pin serde_derive and proc-macro2 versions for Rust 1.56.0 compatibility |
| pastey-test-suite/Cargo.toml | Removed glob dependency constraint and comment that was previously used for Rust 1.56.0 CI fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses compatibility issues for running tests with Rust 1.56.0 in the
pastey-test-suite. The main changes involve updating dependency management in both theCargo.tomlandtest.shfiles to ensure the test suite works correctly with older Rust versions.Dependency management for Rust 1.56.0:
globcrate inCargo.toml, as the specific version constraint is now handled in the test script.test.sh) to add precise version updates forserde_deriveandproc-macro2when running tests on Rust 1.56.0, ensuring compatibility.