Open
Conversation
juliagallucci
approved these changes
May 6, 2024
There was a problem hiding this comment.
Great! Your code is well-commented and executes without error. One suggestion would be to make your code more concise; for example Part A could be written as
def anagram_checker(word_a, word_b):
return sorted(word_a.upper()) == sorted(word_b.upper())
thus limiting the amount of code!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Added code for anagram checker
What did you learn from the changes you have made?
How to write and organize functions and IF statements. I also used tools learnt in the class to convert all letters to upper case and to sort the letters alphabetically.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Can I nest the "upper case" and "sorted" lines of code into one line? I couldn't get it to work so separated it out
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Still trying to get better with syntax. I forget to use the colon where required. Just a matter of practice.
How were these changes tested?
I was able to run the script using VB very easily
A reference to a related issue in your repository (if applicable)
NA
Checklist