Added anagram_checker function with case insensitive option#2
Open
AlexanderTheAlright wants to merge 1 commit intomainfrom
Open
Added anagram_checker function with case insensitive option#2AlexanderTheAlright wants to merge 1 commit intomainfrom
AlexanderTheAlright wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I added in anagram checker function which normalizes the word, sorts them, and then tests if they are equivalent. It also has the option to run case insensitive or not.
What did you learn from the changes you have made?
I learned how to think creatively to develop basic useful functions. I thought about many different approaches to this problem (frequency counting, manual frequency dictionary, using sets) and then decided on what I felt was simplest.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
As mentioned previously, I thought about frequency counting the letters and then testing if they were equivalent, manual frequency dictionary, and using sets to check for anagrams. It took me way too long to realize I could just use the sort function.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
No major challenges. I felt this assignment was relatively straightforward.
How were these changes tested?
I tested them by checking whether or not the words were actually anagrams.
A reference to a related issue in your repository (if applicable)
NA
Checklist