Open
Conversation
kelichiu
reviewed
Feb 17, 2025
| " sorted_word_b = sorted(word_b)\n", | ||
| "\n", | ||
| "# If sorted strings are the same, return True \n", | ||
| " return sorted_word_a == sorted_word_b\n", |
There was a problem hiding this comment.
All the codes can be consolidated to one line:
return sorted(word_a.lower()) == sorted(word_b.lower())
kelichiu
reviewed
Feb 17, 2025
| " # Your code here\n", | ||
| " \n", | ||
| "# Checking string lengths to see if they can be anagrams\n", | ||
| " if len (word_a) != len (word_b):\n", |
There was a problem hiding this comment.
This is not necessary, but good thinking!
kelichiu
approved these changes
Feb 17, 2025
kelichiu
left a comment
There was a problem hiding this comment.
Pass
Code Execution
All code cells execute without errors.
Code Quality
- Code is well-organized, but not concise.
- Codes includes necessary comments for clarity.
- Great use of variable names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code for string length check, changing strings to lower case, and sorting strings
What did you learn from the changes you have made?
I learnt how to define a function, use logic operators and conditionals
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Part 2 of the assignment, as I did not think of using the NOT logic operator right away
How were these changes tested?
Using Visual Studio Code on my laptop
A reference to a related issue in your repository (if applicable)
Checklist