CCDB: make extractFromTFile helper a static method#2427
Merged
ktf merged 1 commit intoAliceO2Group:devfrom Sep 23, 2019
Merged
Conversation
This will simplify reusing the same method for DPL Lifetime::Condition.
sawenzel
approved these changes
Sep 23, 2019
Collaborator
sawenzel
left a comment
There was a problem hiding this comment.
Fine with me if we can reuse some code here.
Barthelemy
approved these changes
Sep 23, 2019
Member
Author
|
@costing We should discuss how to determine the way CCDB objects are stored. Are we planning to use TFile everywhere or do we still plan to have the raw messages as well? How do we encode the kind? Additional HTTP header? |
Collaborator
|
As far as I know we plan to use TFile. The only method dealing with raw message is to retrieve old data. |
Member
Author
|
Fine for me, but was this agreed and ratified by all sub detectors? |
Member
Author
|
Ok. To summarise private discussions between myself, @Barthelemy and @sawenzel :
|
knopers8
pushed a commit
to knopers8/AliceO2
that referenced
this pull request
Oct 23, 2019
This will simplify reusing the same method for DPL Lifetime::Condition.
carlos-soncco
pushed a commit
to carlos-soncco/AliceO2
that referenced
this pull request
Oct 28, 2019
This will simplify reusing the same method for DPL Lifetime::Condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will simplify reusing the same method for DPL Lifetime::Condition.