Conversation
aalkin
commented
Oct 31, 2019
- Reworked tree-parsing algorithm to use ArrowDatumSpec
- Added a test of tree-parsing algorithm
|
There is QualityControl build log (with error) included in the failing build logs, is it supposed to be there? |
|
No, but it's there everywhere since yesterday. I could not yet understand what changed yet. |
|
I see that the template instantiation errors in the QC log are definitely connected with Expressions: it picks up the variant from inside ArrowDatumSpec, which is |
|
The problem itself is due to the fact that the clang used by cling (5.0.2) has a known bug when using GCC headers < 8. The way to fix it is to hide whatever uses variant from cling. Why do you need to expose the ArrowDatum in Expression? Can you simply put an |
* Reworked tree-parsing algorithm to use ArrowDatumSpec * Added a test of tree-parsing algorithm
650dc8e to
21cd5cd
Compare
|
@ktf I moved the parsing helpers into a separate header that is not exposed in include, that should hide variant from cling. |
21cd5cd to
ac7a608
Compare
|
Errors unrelated. This hides variant from ROOT. |