Skip to content

DPL: improve error message when matching resources #4169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Aug 18, 2020
Merged

DPL: improve error message when matching resources #4169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions Framework/Core/src/SimpleResourceManager.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,11 @@
// or submit itself to any jurisdiction.
#include "SimpleResourceManager.h"
#include "Framework/ComputingResource.h"
#include <fmt/format.h>
#include <exception>
#include <stdexcept>

namespace o2
{
namespace framework
namespace o2::framework
{

/// The simplest implementation of this allocates mMaxPorts ports starting from
Expand Down Expand Up @@ -66,9 +65,14 @@ void SimpleResourceManager::notifyAcceptedOffer(ComputingOffer const& offer)
}

if (resourceFound == false) {
throw std::runtime_error("Could not match offer to original resource.");
std::string resources = "Available resources:\n";
for (auto& resource : mResources) {
resources += fmt::format("- ({}, {}, {}, {})\n", resource.hostname.c_str(), resource.cpu, resource.memory, resource.startPort);
}
throw std::runtime_error(fmt::format("Could not match offer (host:{}, cpu:{}, mem:{}, ports:{}) to original resource.\n",
offer.hostname, offer.cpu, offer.memory, offer.rangeSize) +
resources);
}
}

} // namespace framework
} // namespace o2
} // namespace o2::framework