Skip to content

DPL: simplify TableBuilder API#5602

Merged
ktf merged 1 commit intoAliceO2Group:devfrom
ktf:simplify-table-builder
Mar 4, 2021
Merged

DPL: simplify TableBuilder API#5602
ktf merged 1 commit intoAliceO2Group:devfrom
ktf:simplify-table-builder

Conversation

@alibuild
Copy link
Copy Markdown
Collaborator

@alibuild alibuild commented Mar 3, 2021

  • De-templatise TableBuilder::validate
  • Move a few throw statements out of line

@alibuild alibuild requested a review from a team as a code owner March 3, 2021 13:42
@ktf
Copy link
Copy Markdown
Member

ktf commented Mar 3, 2021

@TimoWilken do you understand what is wrong with the clang-format test?

@TimoWilken
Copy link
Copy Markdown
Contributor

TimoWilken commented Mar 3, 2021 •
edited
Loading

@ktf it got confused because you made this PR from the alibuild account, but using a branch from your own fork. It tried to send a PR to alibuild:simplify-table-builder, which didn't work.

I'll see if I can find a way to fix the incorrect destination_branch: '${{ github.event.pull_request.user.login }}:${{ github.event.pull_request.head.ref }}'.
Edit: #5607 should fix it.

@ktf
Copy link
Copy Markdown
Member

ktf commented Mar 3, 2021

@sawenzel @shahor02 any idea of what is wrong with:

=== macro/build_geometry.C - Starting test. Max attempts: 3. Timeout per attempt: 100. ===
=== macro/build_geometry.C - Argument: --name ===
=== macro/build_geometry.C - Argument: macro/build_geometry.C ===
--
=== macro/build_geometry.C - Test attempt 3/3 failed with exit code 129 ===
=== macro/build_geometry.C - Test failed after 3 attempts with 129 ===

346/350 Test #325: macro/o2sim.C ..................................................................***Failed   47.86 sec

?

ktf
ktf previously approved these changes Mar 4, 2021
View reviewed changes
@ktf
DPL: simplify TableBuilder API
768436f 
* De-templatise TableBuilder::validate
* Move a few throw statements out of line
@ktf ktf force-pushed the simplify-table-builder branch from 11a0560 to 768436f Compare March 4, 2021 13:40
@ktf ktf merged commit 71273de into AliceO2Group:dev Mar 4, 2021
@ktf ktf deleted the simplify-table-builder branch March 4, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktf ktf ktf left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alibuild @ktf @TimoWilken