Conversation
| self.fillWithNoise = fillWithNoise | ||
|
|
||
|
|
||
| @renderclientaccess |
There was a problem hiding this comment.
why is this still in this location?
There was a problem hiding this comment.
Are you referring to the pointMatchClient? My thought was that this and the params file would closely mirror what is available as a client in render. the pointMatchClient probably has a higher level of functionality to it than most of the other client calls here, but it fits the bill.
fcollman
left a comment
There was a problem hiding this comment.
other than the PointMatch client seeming to be in an odd location I think this seems good to me.
|
odd that the travis built failed... seems like its passing project=None... |
Codecov Report
@@ Coverage Diff @@
## develop #119 +/- ##
===========================================
- Coverage 94.98% 94.91% -0.08%
===========================================
Files 25 30 +5
Lines 1894 2477 +583
===========================================
+ Hits 1799 2351 +552
- Misses 95 126 +31
Continue to review full report at Codecov.
|
client scripts are broken up to avoid a large module. Will also support future work on using ArgumentParameters base class to better handle render's input parameter reuse.