Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #146 +/- ##
===========================================
+ Coverage 95.88% 95.91% +0.03%
===========================================
Files 30 30
Lines 2091 2107 +16
===========================================
+ Hits 2005 2021 +16
Misses 86 86
Continue to review full report at Codecov.
|
RussTorres
approved these changes
Jul 26, 2019
| y = np.linspace(ymin, ymax, ny) | ||
| xt, yt = np.meshgrid(x, y) | ||
| src = np.vstack((xt.flatten(), yt.flatten())).transpose() | ||
| return src |
Collaborator
There was a problem hiding this comment.
Not really a suggestion, but there is a one-liner to do this (with a different ordering) using mgrid's complex step length:
numpy.mgrid[ymin:ymax:ny*1j, xmin:xmax:nx*1j].reshape(2, -1).T
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThinPlateSplineTransform.scale_coordinates()is a brute-force way to copy a thin plate spline into scaled coordinates. It creates a grid of control points with the original srcPts optional. If small size is important, I think the use case would be to follow this new call withadaptive_mesh_estimate()I did not have immediate success just trying to scale transform parameters. This will work, especially for the first use case of apply_rough.
Also, had to adjust pytest requirements because pytest >= 5 does not work with python 2.7:
https://docs.pytest.org/en/latest/py27-py34-deprecation.html