tilePairClient: add support for more parameters and multi-file support#151
Merged
RussTorres merged 2 commits intoAllenInstitute:developfrom Jan 25, 2021
Merged
Conversation
fcollman
reviewed
Nov 24, 2020
| for jsonfile in jsonfiles: | ||
| os.remove(jsonfile) | ||
|
|
||
| return ((jsondata, jsonfiles) if return_jsonfiles and return_jsondata |
Member
There was a problem hiding this comment.
in the case of delete_json does it make sense to return paths to files that aren't there?
Collaborator
Author
There was a problem hiding this comment.
Practically speaking I don't think so, but since return_jsonfiles defaults to False it seems like we should keep the outputs explicit. Returning an empty list (i.e. just return the files you can expect to find) might work too, and I don't have a strong preference.
fcollman
approved these changes
Nov 24, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #150 and related to saalfeldlab/render#113