Add labels to tile spec#152
Merged
fcollman merged 6 commits intoAllenInstitute:developfrom Jan 22, 2021
Merged
Conversation
RussTorres
approved these changes
Jan 21, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Forrest and Russel,
This change adds support for labels and groupIds to render-python's tile spec wrapper. At Janelia, we primarily use these metadata fields to track acquisition problem areas (e.g. FIBSEM scope restarts). I had meant to submit this pull request last spring but lost track of it for a while. The Travis tests all fail now because of docker pull request limits. Let me know if you need me to get the tests running in this context.
Thanks,
Eric