pointmatch: add functions for fast and deep copy#155
Merged
RussTorres merged 2 commits intodevelopfrom Feb 15, 2021
Merged
Conversation
fcollman
approved these changes
Feb 15, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a function to "copy" pointmatch dictionaries such that changes to the match arrays of the original do not affect the copy.
As background for why this is useful, BigFetA has use cases where it transforms pointmatches in-place. This becomes a problem when doing multiple-step in-memory alignment or trying to interrogate residuals. To be on the safe side I've been copying the matches before each step, which is very expensive on large alignments.
The test I added uses the same match objects (via copy/paste) as the integration test, but I am surprised to see that the format of the dictionaries doesn't match what I was seeing in real pointmatch collections, e.g.
"p": [[1, 2, 3], [1, 2, 3]](pointmatch collection)vs
"p": [[1, 1], [2, 2], [3, 3]](test fixture)This actually doesn't affect the way I have the copy implemented, but I'm not sure if this is a long-standing typo or something that changed without us noticing.