Skip to content

Assignment two#2

Open
Alphanna126 wants to merge 18 commits intomainfrom
assignment-two
Open

Assignment two#2
Alphanna126 wants to merge 18 commits intomainfrom
assignment-two

Conversation

@Alphanna126
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

add changes by modifying the md file with ERD and sql file with new queries

What did you learn from the changes you have made?

Querying with advanced topics

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

NA

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

YES. the last question was a bit challenging

How were these changes tested?

the testing was done in sqlite browser

A reference to a related issue in your repository (if applicable)

NA

Checklist

  • [ X] I can confirm that my changes are working as intended

Copy link
Copy Markdown

@efantinatti efantinatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Ann Paul

Session 1:
1 - OK.

Session 2:
2 - Partial.
--Windowed Functions - Q2: Query os not fully correct. Observe the distinct clause. Check it out.
--Windowed Functions - Q3: Query is not fully correct. Consider using partition.

Session 3:
3 - Partial.
-- CROSS JOIN - Q1: Your query is not displaying the right results. Please consider making it simpler cross-joining with customers and not customer_purchases. Note that you don't need to count customers. The vendor_product_combinations seems correct but not the others. Please check it out.
-- UPDATE - Q1: Query seems Ok but COALLESCE clause is not working and it is returning NULL values. Please check it out.

Final:
4 - Check the aforementioned points prior to merging your feature branch 'assignment-two' to 'main'.

Mark: 60 points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants