Open
Conversation
juliagallucci
approved these changes
Oct 20, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
Great! One note for improvement, you don’t need to explicitly return True or False since the comparison itself already evaluates to a Boolean.
Owner
Author
|
Thanks for the feedback. I’m not sure I completely understand your recommendation of not explicitly returning true or false. Could you please elaborate?Best regards,Anthonia AinaOn Oct 20, 2025, at 4:47 PM, juliagallucci ***@***.***> wrote:
@juliagallucci approved this pull request.
Great! One note for improvement, you don’t need to explicitly return True or False since the comparison itself already evaluates to a Boolean.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Sure! What i mean is sorted_word_a == sorted_word_b returns a True or False, so there's no need to code it as if sorted_word_a == sorted_word_b: |
Owner
Author
|
Oh, makes sense. What I did was like I combined the same instruction instead of just using either of them.Anthonia AinaOn Oct 21, 2025, at 5:22 PM, juliagallucci ***@***.***> wrote:juliagallucci left a comment (AnthoniaAina/python#2)
Sure! What i mean is sorted_word_a == sorted_word_b returns a True or False, so there's no need to code it as
if sorted_word_a == sorted_word_b:
return True
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Renamed the new branch
What did you learn from the changes you have made?
that I should have created the new branch before doing the assignment
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist