Skip to content

Self-Validation Warning: High severity CWE-89 (SQL Injection) vulnerability in WebGoat/Code/SQLiteProfileProvider.cs:412 (1 additional file changed) #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
appsecai-app wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Self-Validation Warning: High severity CWE-89 (SQL Injection) vulnerability in WebGoat/Code/SQLiteProfileProvider.cs:412 (1 additional file changed) #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion WebGoat/Code/SQLiteProfileProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,23 @@ public override int GetNumberOfInactiveProfiles (ProfileAuthenticationOption aut
SqliteConnection cn = GetDbConnectionForProfile ();
try {
using (SqliteCommand cmd = cn.CreateCommand()) {
string authClause;
switch (authenticationOption) {
case ProfileAuthenticationOption.Anonymous:
authClause = " AND IsAnonymous='1' ";
break;
case ProfileAuthenticationOption.Authenticated:
authClause = " AND IsAnonymous='0' ";
break;
case ProfileAuthenticationOption.All:
authClause = " ";
break;
default:
throw new InvalidEnumArgumentException (String.Format ("Unknown ProfileAuthenticationOption value: {0}.", authenticationOption.ToString ()));
}

cmd.CommandText = "SELECT COUNT(*) FROM " + USER_TB_NAME + " u, " + PROFILE_TB_NAME + " p " +
"WHERE u.ApplicationId = $ApplicationId AND u.LastActivityDate <= $LastActivityDate AND u.UserId = p.UserId" + GetClauseForAuthenticationOptions (authenticationOption);
"WHERE u.ApplicationId = $ApplicationId AND u.LastActivityDate <= $LastActivityDate AND u.UserId = p.UserId" + authClause;

if (cn.State == ConnectionState.Closed)
cn.Open ();
Expand Down