Fix itemID/locationID overflow#4
Closed
benny-dreamly wants to merge 1 commit intoArchipelagoMW:mainfrom
benny-dreamly:id-overflow-fix
Closed
Fix itemID/locationID overflow#4benny-dreamly wants to merge 1 commit intoArchipelagoMW:mainfrom benny-dreamly:id-overflow-fix
benny-dreamly wants to merge 1 commit intoArchipelagoMW:mainfrom
benny-dreamly:id-overflow-fix
Conversation
(cherry picked from commit 1a44c90)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes two lines of code to use longs instead of ints to avoid the IDs overflowing. This was causing certain locations/items being sent (specifically in minecraft) to not show up in the client.
Tested building the library and there weren't any errors.