Open
Conversation
Comment on lines
+10
to
+19
| String carName1 = getLabel(1); | ||
| int carSpeed1 = getSpeed(1); | ||
|
|
||
| // get second car info | ||
| String carName2 = getLabel(2); | ||
| int carSpeed2 = getSpeed(2); | ||
|
|
||
| // get third car info | ||
| String carName3 = getLabel(3); | ||
| int carSpeed3 = getSpeed(3); |
There was a problem hiding this comment.
Тут 2 операции повторяются по 3 раза - такой код лучше вынести в цикл с 3мя итерациями
| int carSpeed3 = getSpeed(3); | ||
|
|
||
| // create list of cars | ||
| List<Car> cars = new ArrayList<>(Arrays.asList(new Car(carName1, carSpeed1), new Car(carName2, carSpeed2), new Car(carName3, carSpeed3))); |
There was a problem hiding this comment.
От хранения массива машин и лишнего цикла при определении победителя можно избавиться, если при вводе данных сразу вычислять победителя и хранить его в отдельной переменной, тогда программа будет требовать меньше памяти и работать быстрее
| } | ||
|
|
||
| private static String getLabel(int number) { | ||
| Scanner stringScan = new Scanner(System.in); |
There was a problem hiding this comment.
Количество создаваемых объектов сканнеров можно уменшить, если в классе один раз создать сканнер и переиспользовать его в этих функциях
| System.out.printf("— Введите скорость машины №%d: ", number); | ||
| if (intScan.hasNextInt()) { | ||
| int num = intScan.nextInt(); | ||
| if (num > 0 && num <= 250) return num; |
There was a problem hiding this comment.
Минимальную и максимальную скорости лучше вынести в константы для повышения читабельности кода
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My first homework!