Skip to content

Fix type for customerProfileId#181

Closed
ianneub wants to merge 2 commits intoAuthorizeNet:masterfrom
ianneub:fix-customerProfileId
Closed

Fix type for customerProfileId#181
ianneub wants to merge 2 commits intoAuthorizeNet:masterfrom
ianneub:fix-customerProfileId

Conversation

@ianneub
Copy link
Copy Markdown

@ianneub ianneub commented Jul 18, 2019

customerProfileId should not be a NumericStringsType, it is a simple string.

This will fix the issue in #180 .

@tjbarber
Copy link
Copy Markdown

tjbarber commented Jul 8, 2020

Is there any reason why this is not being accepted? Seems like a reasonable and easy fix.

@hallmatt
Copy link
Copy Markdown

hallmatt commented Jun 2, 2023

Hey @gnongsie - can we get this PR merged into master? Seems to be a good fix for #180

@gnongsie
Copy link
Copy Markdown
Contributor

gnongsie commented Sep 2, 2024

We are relying on the API specification / XSD as the source of truth, and not the documentation, which may be a bit delayed in updating the details.
In any case, the docs are also in agreement that this field should be a numericString.
I am closing this PR as I do not see it as valid anymore.

@gnongsie gnongsie closed this Sep 2, 2024
@gnongsie
Copy link
Copy Markdown
Contributor

gnongsie commented Sep 2, 2024

Actually, correction. I must apologize here.
This change is valid and I will include it in my own pull request.

gnongsie added a commit that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants