This repository was archived by the owner on Feb 10, 2021. It is now read-only.
fix quote issue on download media file#37
Closed
pro0810 wants to merge 1 commit intoBandwidth:masterfrom
Closed
Conversation
jmulford-bw
previously approved these changes
Jun 10, 2019
Contributor
jmulford-bw
left a comment
There was a problem hiding this comment.
LGTM. Unit tests pass and ran on the live API with no issues. Thanks!
Contributor
|
Hey @suhaa18 I spoke with the team and we think a better way to handle this to ensure backwards compatibility would be to only encoded a URL that has not been encoded. Here's the PR for that Feel free to take a look at it and see if it fits your solution. Thanks again! |
|
Resolved elsewhere |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you've checked off all these things before submitting: