Merged
Conversation
Collaborator
Author
|
A new implementation is added, which reduces the number of bytes to 3705. |
|
great |
justin-elementlabs
referenced
this pull request
in elementlabs42/BitVM
Jul 11, 2024
Extract network setting from lower level functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR presents an implementation of the u32_mul, which can be used for ASM_MUL, for 32-bit integers.
It implements:
And their integration tests.
The instruction deals with overflow and resembles RISC-V behavior. It only maintains the keeps the lower 4 bytes of the 32 bit integers. It is possible to similarly implement 64-bit integer operations, but it depends on the ISA.
u32_mul_drop takes 6118 bytes
u32_add takes 85 bytes
roughly 72x, which is expected because u32_mul_drop calls u32_add already 64 times for double-and-add