feat(curves): add hinted is_on_curve check#156
Merged
lucidLuckylee merged 1 commit intoBitVM:mainfrom Jan 2, 2025
Merged
Conversation
Contributor
Author
|
this check is only necessary at the beginning of the pairing algorithm. |
Contributor
Author
|
i'd suggest merging this as well. |
lucidLuckylee
pushed a commit
that referenced
this pull request
Jan 6, 2025
Co-authored-by: Manish Bista <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The G1 and G2 elements of groth16 proof need to be validated to be points on the curve. This PR requests adding hinted version of these scripts.
While non-hinted version of each of these were already present, this version is helpful because of the reduction in script size. For example, test_hinted_g2_affine_is_on_curve uses around 467K script size, while test_g2_affine_is_on_curve uses around 992K.
Unit tests added for each.