chore(deps): bump to rust-bitcoin 0.32.5#158
Merged
lucidLuckylee merged 1 commit intoBitVM:mainfrom Dec 18, 2024
Merged
Conversation
5b2658c to
d95729a
Compare
Contributor
|
@storopoli I merged the blocking PRs. |
d95729a to
b0abc5f
Compare
Contributor
Author
|
This is ready |
storopoli
commented
Dec 18, 2024
Comment on lines
+73
to
+74
| let nonce_hash = sha256::Hash::hash(nonce.to_bytes().as_slice()); | ||
| Message::from_digest_slice(nonce_hash.as_ref()).expect("Failed to create nonce message") |
Contributor
Author
There was a problem hiding this comment.
I decide to .expect() here to not break the API by changing the function signature to return a Result.
Contributor
|
Thank you! |
lucidLuckylee
pushed a commit
that referenced
this pull request
Dec 18, 2024
wz14
pushed a commit
to bitlayer-org/BitVM
that referenced
this pull request
Jan 8, 2025
wz14
pushed a commit
to bitlayer-org/BitVM
that referenced
this pull request
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to rust-bitcoin/rust-bitcoin#3729.
Keeping this as a draft since I am planning to do PRs in more
BitVMorg crates to bumprust-bitcointo 0.32.5 (latest).I had to change one
Messagedeprecation fromrust-secp256k1when updating to0.29.1which is the version thatrust-bitcoin0.32.5re-exports.Also update
musig2to play nice with[email protected].Blocked by: