Merged
Conversation
Member
|
This is great, will test it soon. In the meantime, can you please make the version |
Member
|
👍 |
Contributor
Author
|
Thanks again @alainmeier! Do you have any plans to upload 4.0.0 to pypi? |
Member
|
Definitely, hoping to get that pushed in a couple hours |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@alainmeier thanks for the quick merge on the last pr.
Like I mentioned earlier, here's the v4 endpoing version. I've renamed verifications to people and question_set to question_sets to be consistent with the ruby library. I've also converted all hard tabs to soft tabs with tabstop set to 2 characters as per the last pr. Finally, I changed the minor version number because these are breaking changes, though you may want to change the major version since the api endpoint was updated.
Let me know what you think.
Thanks,
Ryan