Recursion in horizon/scoreboard#1
Closed
Kaperstone wants to merge 1 commit intoBlueMountainsIO:masterfrom
Closed
Conversation
When the server starts up, it adds a remote event named `scoreboard:update` and then it calls the same event, essentially re-calling itself, when the player presses `tab` it will only add a recursion to the already running recursions
Owner
|
It works this way:
|
BlueMountainsIO
pushed a commit
that referenced
this pull request
Dec 12, 2019
Improve AR aim left hand positions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the server starts up, it adds a remote event named
scoreboard:updateand then it calls the same event, essentially re-calling itself, when the player pressestabit will only add a recursion to the already running recursions.This commit fixes this, by splitting the event to two pieces, one that gets the all the online player data on the server side and the second that does the rest on the client side.