Conversation
There was a problem hiding this comment.
Updated save button to show "Save" since some modules allow both file and image saving
There was a problem hiding this comment.
General comment for later to-dos. We could update the UI to maybe change the Download VCF file to be positioned better, and maybe adjust the color to be more visible? ie a light purple
alex-sandercock
left a comment
There was a problem hiding this comment.
Overall looks nice, though there are a few bugs that need to be fixed:
- PCA plot does not update when the user changes which column to use to color the points
- The manhattan plot x-axis changes only apply to the "all" figure
There was a problem hiding this comment.
- a bug has been introduced in the PCA module:
- When the user updates the "Color Variable" column selected, the plot does not update as intended
There was a problem hiding this comment.
Fixed! But I noticed that the 3D graphics don't update with the "Color Category" selection. I added a tag "2D-Plot only" to the button label. Is that good?
There was a problem hiding this comment.
That's perfect for now since the users can remove samples within the 3D plotly window
There was a problem hiding this comment.
- We will need to generalize the warning message and adapt the warning message to trigger depending on what time of file format the user is trying to convert.
There was a problem hiding this comment.
Next pull request has it! 🚀
There was a problem hiding this comment.
- The update to the manhattan plot x-axis labels only applies to the "all" model selection figure, and not the other specific models
CITATION file added in inst/
With that, the R function citation("BIGapp") works (update when published)
Convert to VCF
Dosage Calling
VCF filtering
Genomic Diversity
PCA
DAPC
Predictive Ability
Genomic Prediction