feat: input-checkbox: console error when aria-label property set#6785
Merged
feat: input-checkbox: console error when aria-label property set#6785
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
dlockhart
approved these changes
Apr 21, 2026
Member
dlockhart
left a comment
There was a problem hiding this comment.
Seems good to me -- we could also search for these errors in the JS error tracking stuff to find unexpected usages before removing.
|
🎉 This PR is included in version 3.237.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GAUD-9677
Adds a console error when aria-label is set in case there were any places setting it in an unexpected way (since it's tricky to do a full search on this) so that we can clean them up before full removal.
This could be considered excessive so let me know thoughts on this; on one hand a non-sighted user would still get the information communicated to them using the
aria-labelbut on the other hand it wouldn't be getting communicated in the expected way.