Merged
Conversation
Contributor
petrstehlik
commented
Oct 5, 2017
- Introduces new modular system described in Introduce better module system #17 with bootstrapping
- rename root folders to better describe structure
- rewrite dbConnector to support NoSQL and SQL with named instances
- Write everything to wiki pages (move-modules documentation #22)
- integrate Travis CI
- fix error AppModule is not NgModule
- merge Don't rewrite Content-type header in all HTTP requests #15
- many issues and bugs fixed: ERROR TypeError: this.config.addressgroups is undefined #11, Errors on querying Nemea events #12, First and last name are not saved during user creation #13, User role cannot be set (always Guest) #14, Fix bootstrap.py with no modules #19, Cannot create admin user with setup page #20
Removes dependency on reporter_conf and fixes config
HttpInterceptor currently rewrites headers in all requests and sets Content-Type to application/json. However, there are usecases when the application needs to pass its own headers or keep the different Content-type. This commit changes HttpInterceptor to keep the original headers, add what it needs (authentication) and if not set 'specific-content-type' header, it sets the Content-Type to application/json.
Don't rewrite Content-type header in all HTTP requests
The problem was caused by a conversion from JSON to dictionary. In the end, all JSON values are strings. When original python code checked for instance of int, it always evaluated to False, anything evaluated as a string and since there was not a test for role == '0' or similar tests, it was impossible to properly set roles. By trying to cast the value to int and test for strings when that fails, we can fix the bug.
This check is useless, it needs just to compare to string and otherwise return Role.guest
Devel user fix
This breaks the polyfills bundle which now needs extra imports
Configurator now uses only one ConfigParser instance and in case of duplicit entries in configs, the items are overwritten. Fixes #9
This also remove AppModule is not NgModule error
* devel: FE: remove init function before bootstrap and fetch config in HTTP
With the exception of Nemea-Dashboard and Nemea-Supervisor, bootstrap script is able to set up modules properly (creating symlinks, generating modules.ts). It also merges any dependency file with lgui base dependencies. Dependencies are completely optional and you can use only a subset or even none of them.
Warning was printed but skip did not really occur.
User is not inputting old password to update form
* 'move-modules' of https://github.com/CESNET/liberouter-gui: Remove example python code
Modularize the Whole LGUI
…into auth-flow * 'auth-flow' of https://github.com/CESNET/liberouter-gui: Users: split user and session info
If some of the requirements files did not end with a newline, it could cause a problem. Fixed now
#28 Bootstrap: Fix requirements file generation
#27 Authorization Flow
* Fix CESNET/Nemea-Dashboard#9 * Fix #32 in NEMEA Dashboard and NEMEA Configuration
NEMEA Dashboard: CESNET/Nemea-Dashboard@b723aec
* master:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.