Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt at grouping machine directories in subfolders based on the hostname.
So for hostname xxx-yyy-zzz, the directory structure in $HOME/machines could be:
...and combinations like that. I've paid a little attention to the order of priority like respecting a match to the exact hostname first and putting the combinations with two elements later, but otherwise haven't tested extensively. Since a hostname should be unique in a machines environment, issues should only occur if multiple directory trajectories could match the hostname, which should only be the case during development or implementation of this.
There might be some PyExpLabSys functions that try to get the machine folder via hostname - I should check up on that before considering a merge here.