Open
Conversation
dwz92
suggested changes
Sep 10, 2024
dwz92
left a comment
There was a problem hiding this comment.
- replace all of your
printstatement withreturn - your function is not returning anything for the case where two words have different length in both Part 1 and 2
- Part 2, by case sensitive, we want to see you handling the case where the user can choose to check for case sensitive anagrams
Than means, your function in Part 2 should pass the case:
anagram_checker("Slient", "Listen", True) # False
anagram_checker("Slient", "listen", False) # True
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Yes, was thinking about doing it directly on here but Daniel taught me how to navigate using VS Code
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Yes, wasn't clear about pulling/pushing data from/to gitbash to here, but learning
How were these changes tested?
in code, python. Successful
A reference to a related issue in your repository (if applicable)
NA
Checklist