Conversation
Collaborator
Author
|
Reverted update to deploy.yml as per CitrineInformatics/common-gh-actions#3 |
anoto-moniz
reviewed
May 15, 2024
Comment on lines
+13
to
+17
| # Allow only one concurrent deployment, skipping runs queued between the run in-progress and latest queued. | ||
| # However, do NOT cancel in-progress runs as we want to allow these production deployments to complete. | ||
| concurrency: | ||
| group: "pages" | ||
| cancel-in-progress: false |
Contributor
There was a problem hiding this comment.
I found that this stanza actually causes the workflow to be cancelled, since it also exists in the common actions version. I think best is to leave it in the common actions workflow, so each caller doesn't have to worry about it.
Collaborator
Author
There was a problem hiding this comment.
Sounds reasonable. 👍
anoto-moniz
requested changes
May 15, 2024
Contributor
anoto-moniz
left a comment
There was a problem hiding this comment.
Just that one issue. Other than that, looks good!
anoto-moniz
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEMD Python PR
Description
This PR moves to using the common-gh-actions repo instead of locally defined actions.
PR Type:
Adherence to team decisions