Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
手上没 linux 环境,要不你测一下(? |
等下周末( |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
? |
| private static string? TryGetDefaultDesktopFileFromXdgMime() | ||
| { | ||
| if (!TryRunProcess("xdg-mime", $"query default {MimeType}", out var output)) | ||
| { | ||
| return null; | ||
| } | ||
|
|
||
| return output?.Trim(); | ||
| } |
There was a problem hiding this comment.
为什么要动 xdg-mime,这东西不是应该用户自己改的吗
HelloWRC
left a comment
There was a problem hiding this comment.
经过测试功能没有问题,但别忘了在应用设置和 oobe 页面中恢复被屏蔽的 Uri 相关选项的显示。
-
ClassIsland/ClassIsland/Views/SettingPages/GeneralSettingsPage.axaml
Lines 63 to 75 in 2f30572
-
ClassIsland/ClassIsland/Views/SettingsWindowNew.axaml
Lines 201 to 209 in 714b766
-
ClassIsland/ClassIsland/Views/WelcomePages/SystemPage.axaml
Lines 62 to 71 in c766d67
|
|
||
| public static async Task CreateUriHandlerDesktopShortcutAsync(string path = "") | ||
| { | ||
| if (AppBase.Current.PackagingType == "deb") |
There was a problem hiding this comment.
deb 打包已经有系统级的注册流程了啊
这个 handler 是专门给不用 deb 安装的时候用的
|
已然恢复被屏蔽的 Uri 相关选项的显示在 ab5a42b /v |
IsHPDuwu
left a comment
There was a problem hiding this comment.
2026/04/02 06:41:10 | fail | ClassIsland.Views.WelcomeWindow | 无法创建快捷方式。
System.ArgumentException: The value cannot be an empty string. (Parameter 'path')
at System.ArgumentException.ThrowNullOrEmptyException(String argument, String paramName)
at System.IO.Directory.CreateDirectory(String path)
at ClassIsland.Helpers.ShortcutHelpers.CreateFreedesktopShortcutAsync(String path)
at ClassIsland.Views.WelcomeWindow.CreateShortcutsFreedesktop()
at ClassIsland.Views.WelcomeWindow.CommandBindingFinishWizard_OnExecuted(Object sender, ExecutedRoutedEventArgs e)
貌似还存在一些问题,我周末看看
使用如下配置在 windows 平台下完成了 linux 平台的编译
PS D:\Documents\GitHub\ClassIsland> .\build.cmd PublishApp
PowerShell Desktop version 5.1.26100.7920
Microsoft (R) .NET SDK version 9.0.312
███╗ ██╗██╗ ██╗██╗ ██╗███████╗
████╗ ██║██║ ██║██║ ██╔╝██╔════╝
██╔██╗ ██║██║ ██║█████╔╝ █████╗
██║╚██╗██║██║ ██║██╔═██╗ ██╔══╝
██║ ╚████║╚██████╔╝██║ ██╗███████╗
╚═╝ ╚═══╝ ╚═════╝ ╚═╝ ╚═╝╚══════╝
NUKE Execution Engine version 9.0.4 (Windows,.NETCoreApp,Version=v8.0)
OsName:
¬ linux
Arch:
¬ x64
Package:
¬ folder
BuildType:
¬ full
BuildName:
¬ chore_linux_uri_build_02
测试用 linux 环境为
.-/+oossssoo+/-. root@ishpduwu-VMware20-1
`:+ssssssssssssssssss+:` ------------------------
-+ssssssssssssssssssyyssss+- OS: Ubuntu 24.04.4 LTS x86_64
.ossssssssssssssssssdMMMNysssso. Host: VMware20,1 None
/ssssssssssshdmmNNmmyNMMMMhssssss/ Kernel: 6.17.0-19-generic
+ssssssssshmydMMMMMMMNddddyssssssss+ Uptime: 1 hour, 42 mins
/sssssssshNMMMyhhyyyyhmNMMMNhssssssss/ Packages: 1676 (dpkg), 10 (snap)
.ssssssssdMMMNhsssssssssshNMMMdssssssss. Shell: bash 5.2.21
+sssshhhyNMMNyssssssssssssyNMMMysssssss+ Resolution: 1280x800
ossyNMMMNyMMhsssssssssssssshmmmhssssssso DE: GNOME 46.0
ossyNMMMNyMMhsssssssssssssshmmmhssssssso WM: Mutter
+sssshhhyNMMNyssssssssssssyNMMMysssssss+ WM Theme: Adwaita
.ssssssssdMMMNhsssssssssshNMMMdssssssss. Theme: Yaru [GTK2/3]
/sssssssshNMMMyhhyyyyhdNMMMNhssssssss/ Icons: Yaru [GTK2/3]
+sssssssssdmydMMMMMMMMddddyssssssss+ Terminal: gnome-terminal
/ssssssssssshdmNNNNmyNMMMMhssssss/ CPU: Intel i7-8565U (4) @ 1.992GHz
.ossssssssssssssssssdMMMNysssso. GPU: 00:0f.0 VMware SVGA II Adapter
-+sssssssssssssssssyyyssss+- Memory: 1456MiB / 3867MiB
:+ssssssssssssssssss+:
.-/+oossssoo+/-.
这个 Pull Request 做了什么?
支持 linux 下的 uri
完成了 linux 下的 2 种实现方式
相关 Issue
fix #1710
检查清单
好吧是被 P 薅过来写着玩的()
手上没 Linux 环境只能看着写了)