Mark task as done without parent ProcessList task#95535
Merged
antonio2368 merged 1 commit intomasterfrom Jan 30, 2026
Merged
Conversation
Contributor
|
Workflow [PR], commit [26a7291] Summary: ❌
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the process list cleanup path by moving the cancellation checker notification outside of the parent process list lock, reducing lock contention during query destruction.
Changes:
- Move
CancellationChecker::getInstance().appendDoneTasks(*it)call before acquiring the ProcessList mutex - Modernize mutex lock syntax in
appendDoneTasksmethod
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Interpreters/ProcessList.cpp | Moved appendDoneTasks call outside the parent mutex lock to reduce contention |
| src/Interpreters/CancellationChecker.cpp | Updated mutex lock to use CTAD (Class Template Argument Deduction) |
robot-clickhouse
added a commit
that referenced
this pull request
Feb 2, 2026
This was referenced Feb 2, 2026
robot-clickhouse
added a commit
that referenced
this pull request
Feb 2, 2026
This was referenced Feb 2, 2026
robot-clickhouse
added a commit
that referenced
this pull request
Feb 2, 2026
This was referenced Feb 2, 2026
robot-clickhouse
added a commit
that referenced
this pull request
Feb 2, 2026
robot-clickhouse
added a commit
that referenced
this pull request
Feb 2, 2026
clickhouse-gh bot
added a commit
that referenced
this pull request
Feb 2, 2026
Backport #95535 to 26.1: Mark task as done without parent ProcessList task
clickhouse-gh bot
added a commit
that referenced
this pull request
Feb 2, 2026
Backport #95535 to 25.12: Mark task as done without parent ProcessList task
clickhouse-gh bot
added a commit
that referenced
this pull request
Feb 2, 2026
Backport #95535 to 25.11: Mark task as done without parent ProcessList task
serxa
added a commit
that referenced
this pull request
Feb 2, 2026
Backport #95535 to 25.8: Mark task as done without parent ProcessList task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Should reduce lock contention.
cc @yariks5s any reason not to do it like this?
Documentation entry for user-facing changes