Fix assertion failure in applyUncommittedState for deltas without paths#95846
Merged
antonio2368 merged 3 commits intomasterfrom Feb 3, 2026
Merged
Conversation
…aths The `applyUncommittedState` function was calling `applyDelta` for all deltas without checking if the delta has a path. However, some delta types (`AddAuthDelta`, `CloseSessionDelta`, etc.) are created with empty paths and require separate handling. This caused a `chassert(!delta.path.empty())` assertion failure during snapshot application in multinode Keeper setups. The fix adds the same path checking logic that already exists in `applyDeltas`: only call `applyDelta` when the path is non-empty, and handle `AddAuthDelta` and `CloseSessionDelta` separately. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
|
Workflow [PR], commit [27ced5e] Summary: ❌
|
2c7e52d to
27ced5e
Compare
antonio2368
approved these changes
Feb 3, 2026
robot-clickhouse
added a commit
that referenced
this pull request
Feb 3, 2026
…ate` for deltas without paths
robot-clickhouse
added a commit
that referenced
this pull request
Feb 3, 2026
…ate` for deltas without paths
robot-clickhouse
added a commit
that referenced
this pull request
Feb 3, 2026
…tate` for deltas without paths
robot-clickhouse
added a commit
that referenced
this pull request
Feb 3, 2026
…tate` for deltas without paths
robot-clickhouse
added a commit
that referenced
this pull request
Feb 3, 2026
…ate` for deltas without paths
clickhouse-gh bot
added a commit
that referenced
this pull request
Feb 3, 2026
Backport #95846 to 26.1: Fix assertion failure in `applyUncommittedState` for deltas without paths
clickhouse-gh bot
added a commit
that referenced
this pull request
Feb 3, 2026
Backport #95846 to 25.12: Fix assertion failure in `applyUncommittedState` for deltas without paths
antonio2368
added a commit
that referenced
this pull request
Feb 4, 2026
Backport #95846 to 25.3: Fix assertion failure in `applyUncommittedState` for deltas without paths
antonio2368
added a commit
that referenced
this pull request
Feb 4, 2026
Backport #95846 to 25.8: Fix assertion failure in `applyUncommittedState` for deltas without paths
antonio2368
added a commit
that referenced
this pull request
Feb 4, 2026
Backport #95846 to 25.11: Fix assertion failure in `applyUncommittedState` for deltas without paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
applyUncommittedStatefunction was callingapplyDeltafor all deltas without checking if the delta has a path. However, some delta types (AddAuthDelta,CloseSessionDelta, etc.) are created with empty paths and require separate handling.This caused a
chassert(!delta.path.empty())assertion failure during snapshot application in multinode Keeper setups.The fix adds the same path checking logic that already exists in
applyDeltas: only callapplyDeltawhen the path is non-empty, and handleAddAuthDeltaandCloseSessionDeltaseparately.Changelog category (leave one):
See https://s3.amazonaws.com/clickhouse-test-reports/json.html?REF=master&sha=5c363d43316a01d8b2b9ffe4a2f66a64f76df6f5&name_0=MasterCI&name_1=Integration%20tests%20%28amd_asan%2C%20db%20disk%2C%20old%20analyzer%2C%204%2F6%29&name_1=Integration%20tests%20%28amd_asan%2C%20db%20disk%2C%20old%20analyzer%2C%204%2F6%29