Merged
Conversation
Contributor
|
Workflow [PR], commit [4d63898] Summary: ❌
|
serxa
approved these changes
Feb 5, 2026
Member
serxa
left a comment
There was a problem hiding this comment.
Probably we should also check other places with ?:
pamarcos
approved these changes
Feb 5, 2026
Member
|
test3.cpp#include <cstddef>
#include <iostream>
struct SettingFieldNumber
{
using Type = size_t;
using ValueType = size_t;
Type value;
bool changed = false;
explicit SettingFieldNumber(Type x = 0);
SettingFieldNumber(const SettingFieldNumber & o)
: value(o.value), changed(o.changed)
{}
virtual SettingFieldNumber & operator=(Type x);
SettingFieldNumber & operator=(const SettingFieldNumber & o)
{
if (this != &o)
{
value = o.value;
changed = o.changed;
}
return *this;
}
operator Type() const { return value; } /// NOLINT
};
int main()
{
std::cout << "SettingFieldNumber:: size: " << sizeof(getenv("foo") ? SettingFieldNumber() : 0) << "\n";
std::cout << "SettingFieldNumber:: size: " << sizeof(getenv("foo") ? SettingFieldNumber().value : 0) << "\n";
return 0;
}But likely enabling it will have too much of this warnings... |
Member
Author
|
@azat Let's try and see in a different PR |
robot-clickhouse
added a commit
that referenced
this pull request
Feb 5, 2026
This was referenced Feb 5, 2026
robot-clickhouse
added a commit
that referenced
this pull request
Feb 5, 2026
This was referenced Feb 5, 2026
robot-clickhouse
added a commit
that referenced
this pull request
Feb 5, 2026
This was referenced Feb 5, 2026
robot-clickhouse
added a commit
that referenced
this pull request
Feb 5, 2026
This was referenced Feb 5, 2026
robot-clickhouse
added a commit
that referenced
this pull request
Feb 5, 2026
antonio2368
added a commit
that referenced
this pull request
Feb 6, 2026
Backport #96048 to 25.3: Fix global profiler values
antonio2368
added a commit
that referenced
this pull request
Feb 6, 2026
Backport #96048 to 25.8: Fix global profiler values
antonio2368
added a commit
that referenced
this pull request
Feb 6, 2026
Backport #96048 to 25.11: Fix global profiler values
antonio2368
added a commit
that referenced
this pull request
Feb 6, 2026
Backport #96048 to 25.12: Fix global profiler values
antonio2368
added a commit
that referenced
this pull request
Feb 6, 2026
Backport #96048 to 26.1: Fix global profiler values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix period for global profilers (controlled by
global_profiler_real_time_period_nsandglobal_profiler_cpu_time_period_ns). Instead of set value, a truncated value was used, causing profiler to wakeup more than intended.Documentation entry for user-facing changes