Fix incorrect seek in AsynchronousReadBufferFromFileDescriptor with O_DIRECT#99678
Merged
alexey-milovidov merged 6 commits intomasterfrom Mar 18, 2026
Merged
Fix incorrect seek in AsynchronousReadBufferFromFileDescriptor with O_DIRECT#99678alexey-milovidov merged 6 commits intomasterfrom
alexey-milovidov merged 6 commits intomasterfrom
Conversation
…_DIRECT getPosition() did not account for bytes_to_ignore, which is set when O_DIRECT alignment rounds the seek position down. This caused the NOOP and in-buffer seek checks to produce wrong results, leading to corrupted reads of Variant subcolumns from wide MergeTree parts with min_bytes_to_use_direct_io=1. The same bug was already fixed in AsynchronousBoundedReadBuffer (remote filesystems), which correctly includes bytes_to_ignore in its getPosition().
Contributor
alexey-milovidov
approved these changes
Mar 17, 2026
1 task
Contributor
LLVM Coverage Report
PR changed lines: PR changed-lines coverage: 68.00% (17/25, 0 noise lines excluded) |
robot-clickhouse
added a commit
that referenced
this pull request
Mar 18, 2026
…FromFileDescriptor with O_DIRECT
robot-clickhouse
added a commit
that referenced
this pull request
Mar 18, 2026
…FromFileDescriptor with O_DIRECT
robot-clickhouse
added a commit
that referenced
this pull request
Mar 18, 2026
…rFromFileDescriptor with O_DIRECT
robot-clickhouse
added a commit
that referenced
this pull request
Mar 18, 2026
…FromFileDescriptor with O_DIRECT
robot-clickhouse
added a commit
that referenced
this pull request
Mar 18, 2026
…FromFileDescriptor with O_DIRECT
clickhouse-gh bot
added a commit
that referenced
this pull request
Mar 18, 2026
Backport #99678 to 26.1: Fix incorrect seek in AsynchronousReadBufferFromFileDescriptor with O_DIRECT
clickhouse-gh bot
added a commit
that referenced
this pull request
Mar 18, 2026
Backport #99678 to 26.2: Fix incorrect seek in AsynchronousReadBufferFromFileDescriptor with O_DIRECT
clickhouse-gh bot
added a commit
that referenced
this pull request
Mar 18, 2026
Backport #99678 to 25.12: Fix incorrect seek in AsynchronousReadBufferFromFileDescriptor with O_DIRECT
alexey-milovidov
added a commit
that referenced
this pull request
Mar 19, 2026
Backport #99678 to 25.8: Fix incorrect seek in AsynchronousReadBufferFromFileDescriptor with O_DIRECT
alexey-milovidov
added a commit
that referenced
this pull request
Mar 19, 2026
Backport #99678 to 25.3: Fix incorrect seek in AsynchronousReadBufferFromFileDescriptor with O_DIRECT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix incorrect seek in AsynchronousReadBufferFromFileDescriptor with O_DIRECT. Closes #99358
Documentation entry for user-facing changes