Skip to content

Fix logical error with datalakes tables iteration#99739

Merged
scanhex12 merged 3 commits intomasterfrom
scanhex12-patch-1
Mar 18, 2026
Merged

Fix logical error with datalakes tables iteration#99739
scanhex12 merged 3 commits intomasterfrom
scanhex12-patch-1

Conversation

@scanhex12
Copy link
Copy Markdown
Member

@scanhex12 scanhex12 commented Mar 17, 2026

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix query:

SELECT
    database,
    name,
    engine
FROM system.tables
WHERE database = 'unity'
SETTINGS show_data_lake_catalogs_in_system_tables = 1, database_datalake_require_metadata_access = 0

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 17, 2026 •
edited
Loading

Workflow [PR], commit [6889071]

Summary: ⏳

job_name test_name status info comment
Integration tests (amd_asan, targeted) failure
test_move_ttl_broken_compatibility/test.py::test_bc_compatibility[10-10] FAIL cidb
test_move_ttl_broken_compatibility/test.py::test_bc_compatibility[4-10] FAIL cidb
test_move_ttl_broken_compatibility/test.py::test_bc_compatibility[2-10] FAIL cidb
test_move_ttl_broken_compatibility/test.py::test_bc_compatibility[8-10] FAIL cidb
test_move_ttl_broken_compatibility/test.py::test_bc_compatibility[7-10] FAIL cidb
test_move_ttl_broken_compatibility/test.py::test_bc_compatibility[9-10] FAIL cidb
test_move_ttl_broken_compatibility/test.py::test_bc_compatibility[3-10] FAIL cidb
test_move_ttl_broken_compatibility/test.py::test_bc_compatibility[6-10] FAIL cidb
test_move_ttl_broken_compatibility/test.py::test_bc_compatibility[5-10] FAIL cidb
Stateless tests (amd_debug, distributed plan, s3 storage, parallel) failure
04004_integral_col_comparison_with_float_key_condition FAIL cidb
AST fuzzer (amd_debug) failure
Segmentation fault (STID: 5737-6ff0) FAIL cidb

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Mar 17, 2026
@serxa serxa self-assigned this Mar 17, 2026
@alesapin
Copy link
Copy Markdown
Member

alesapin commented Mar 17, 2026

Very poor changelog entry. What does it mean -- fix query?

@alexey-milovidov alexey-milovidov mentioned this pull request Mar 18, 2026
Merged
1 task
@scanhex12 scanhex12 enabled auto-merge March 18, 2026 13:05
@scanhex12 scanhex12 added this pull request to the merge queue Mar 18, 2026
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 18, 2026

LLVM Coverage Report

Metric Baseline Current Δ
Lines 83.80% 83.70% -0.10%
Functions 23.90% 23.90% +0.00%
Branches 76.30% 76.30% +0.00%

PR changed lines: PR changed-lines coverage: 9.09% (1/11, 0 noise lines excluded)
Diff coverage report
Uncovered code

Merged via the queue into master with commit 16ef1e2 Mar 18, 2026
157 of 163 checks passed
@scanhex12 scanhex12 deleted the scanhex12-patch-1 branch March 18, 2026 13:17
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Mar 18, 2026
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 18, 2026
This was referenced Mar 18, 2026
Closed
Merged
robot-clickhouse added a commit that referenced this pull request Mar 18, 2026
@robot-clickhouse
Backport #99739 to 25.8: Fix logical error with datalakes tables iter…
cedb493 
…ation
This was referenced Mar 18, 2026
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Mar 18, 2026
@robot-clickhouse
Backport #99739 to 25.12: Fix logical error with datalakes tables ite…
4c9b065 
…ration
This was referenced Mar 18, 2026
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Mar 18, 2026
@robot-clickhouse
Backport #99739 to 26.1: Fix logical error with datalakes tables iter…
4f1a13e 
…ation
This was referenced Mar 18, 2026
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Mar 18, 2026
@robot-clickhouse
Backport #99739 to 26.2: Fix logical error with datalakes tables iter…
89137ca 
…ation
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Mar 18, 2026
Merged
clickhouse-gh bot added a commit that referenced this pull request Mar 18, 2026
@clickhouse-gh
Merge pull request #99899 from ClickHouse/backport/26.2/99739
b4412c4 
Backport #99739 to 26.2: Fix logical error with datalakes tables iteration
clickhouse-gh bot added a commit that referenced this pull request Mar 18, 2026
@clickhouse-gh
Merge pull request #99895 from ClickHouse/backport/25.12/99739
5419d4b 
Backport #99739 to 25.12: Fix logical error with datalakes tables iteration
clickhouse-gh bot added a commit that referenced this pull request Mar 18, 2026
@clickhouse-gh
Merge pull request #99893 from ClickHouse/backport/25.8/99739
228561f 
Backport #99739 to 25.8: Fix logical error with datalakes tables iteration
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Mar 19, 2026
Algunenano added a commit that referenced this pull request Mar 24, 2026
@Algunenano @claude
Fix CHANGELOG.md review comments
0fa097e 
- Remove unresolved `TODO: Support for materialized CTE.` placeholder
- Rename `unicode_word` to `unicodeWord` and remove stop words mention per reviewer feedback
- Replace truncated "Fix query:." with proper description from PR #99739

#100528

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
nikitamikhaylov added a commit that referenced this pull request Mar 31, 2026
@nikitamikhaylov
Merge pull request #99897 from ClickHouse/backport/26.1/99739
47938ef 
Backport #99739 to 26.1: Fix logical error with datalakes tables iteration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serxa serxa serxa approved these changes

Assignees

@serxa serxa

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@scanhex12 @alesapin @serxa @robot-ch-test-poll1 @robot-ch-test-poll4 @alexey-milovidov