Fixed FIleExistsError in the _save method#3
Merged
Code0x58 merged 2 commits intoCode0x58:masterfrom May 6, 2020
JakubBlaha:master
Merged
Fixed FIleExistsError in the _save method#3Code0x58 merged 2 commits intoCode0x58:masterfrom JakubBlaha:master
Code0x58 merged 2 commits intoCode0x58:masterfrom
JakubBlaha:master
Conversation
Owner
|
Thanks for reporting this! I've just added Windows to the tests in Travis to highlight the failure, so rebasing your change will show that it fixed the issue. I think a better solution here is to use if sys.version_info >= (3, 3):
os.replace(temp, self._path)
elif os.name == "windows":
os.remove(self._path)
os.rename(temp, self._path)
else:
os.rename(temp, self._path) |
Owner
|
Thanks! I'll make a release for this tonight |
Contributor
Author
|
Thank you too! I can finally use this in my windows scripts. |
Owner
|
This/Windows support is now released as 1.2.0 is available on pypi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an error occuring when calling the
_savemethod.