Skip to content

__setitem__ key type check #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JakubBlaha wants to merge 7 commits into from
Closed

__setitem__ key type check #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7568489
Fixed FIleExistsError in the _save method
JakubBlaha May 3, 2020
c8d444c
Applied proposed solution to the FileExistsError
JakubBlaha May 6, 2020
b052e86
Added .gitinore
JakubBlaha May 12, 2020
e2708f7
Updated .gitignore
JakubBlaha May 13, 2020
6db6d68
Merge remote-tracking branch 'upstream/master'
JakubBlaha May 13, 2020
9d65c59
Removed gitignore
JakubBlaha May 13, 2020
99c4aa3
Add __setitem__ key type check
JakubBlaha May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions jsonstore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,9 @@ def __get_obj(self, full_path):
return obj

def __setitem__(self, name, value):
if type(name) is not str:
raise TypeError("Key must be of type 'str' but '%s' was given" % name.__class__.__name__)

path, _, key = name.rpartition(".")
if self._valid_object(value):
dictionary = self.__get_obj(path)
Expand Down
3 changes: 1 addition & 2 deletions test_jsonstore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,7 @@ def assign(value):
self.assertRaises(AttributeError, assign(None for i in range(2)))

def test_assign_bad_keys(self):
# FIXME: a ValueError would make more sense
self.assertRaises(AttributeError, self._setitem(1, 2))
self.assertRaises(TypeError, self._setitem(1, 2))

def test_retrieve_values(self):
for name, value in self.TEST_DATA:
Expand Down