Skip to content

Fix Expo Android CodePush bundle wiring for wrapped ReactNativeHost#45

Closed
kmsbernard wants to merge 5 commits intomasterfrom
codex/pr-43-expo-android-fix
Closed

Fix Expo Android CodePush bundle wiring for wrapped ReactNativeHost#45
kmsbernard wants to merge 5 commits intomasterfrom
codex/pr-43-expo-android-fix

Conversation

@kmsbernard
Copy link
Copy Markdown

This branch is based on the changes from #43 and adds the missing Expo Android wiring for the actual generated MainApplication.kt shape.

What changed:

  • handle Expo ReactNativeHostWrapper(...) templates by inserting a getJSBundleFile() override on the wrapped host
  • keep the jsBundleFilePath path for templates that use getDefaultReactHost(...)
  • add Expo Android regression coverage in test/test.ts so the generated MainApplication.kt is verified during test setup

Validation:

  • npm run build:tests
  • manually re-packed the plugin into a generated Expo app and ran expo prebuild --clean under Node 20
  • verified the generated Android MainApplication.kt now contains CodePush.getJSBundleFile() wiring for the wrapper-based template

Notes:

  • full Android emulator e2e could not run in this environment because the Android SDK tools (emulator, adb, sdkmanager) are not installed
  • expo prebuild on the temporary app completed Android generation but later failed during iOS CocoaPods install due a minimum deployment target mismatch; Android output was generated before that failure

@kmsbernard kmsbernard closed this Apr 8, 2026
@kmsbernard kmsbernard deleted the codex/pr-43-expo-android-fix branch April 8, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants