This repository was archived by the owner on Oct 2, 2024. It is now read-only.
Scot class 5 - zoo webpage - Puoja#36
Closed
sPuoja wants to merge 2 commits intoCodeYourFuture:mainfrom
Closed
Conversation
bonboh
approved these changes
Jun 13, 2021
| } | ||
|
|
||
| .image-container img:first-of-type { | ||
| /*.image-container img:first-of-type { |
Contributor
There was a problem hiding this comment.
Software teams normally don't leave commented code, so we can remove it
|
|
||
| .giraffe h2 { | ||
| color: #ef6f6c; | ||
| .giraffe h2, h3, p { |
Contributor
There was a problem hiding this comment.
Suggested change
| .giraffe h2, h3, p { | |
| .giraffe h2, .giraffe h3, .giraffe p { |
The h3 and p selectors will apply to all h3s and ps on the webpage, but we only want them to apply to the giraffe section so we can update them to .giraffe h3 and .giraffe p to only apply within the giraffe section
| } | ||
|
|
||
|
|
||
| .education-container button:hover,:focus{ |
Contributor
There was a problem hiding this comment.
Suggested change
| .education-container button:hover,:focus{ | |
| .education-container button:hover, .education-container button:focus{ |
Like my other comment, we should update :focus to apply to only the buttons in the learning section
|
|
||
|
|
||
| .education-container button:hover,:focus{ | ||
| background-color: tomato; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.