Skip to content
This repository was archived by the owner on Oct 2, 2024. It is now read-only.

Kudrat_Glasgow_Class_5_Week_2#40

Closed
ku562 wants to merge 3 commits intoCodeYourFuture:mainfrom
ku562:main
Closed

Kudrat_Glasgow_Class_5_Week_2#40
ku562 wants to merge 3 commits intoCodeYourFuture:mainfrom
ku562:main

Conversation

@ku562
Copy link
Copy Markdown

@ku562 ku562 commented Jun 4, 2021

No description provided.

Copy link
Copy Markdown
Contributor

@bonboh bonboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good effort @ku562! I've left a few suggestions and tips for you to read 👍

<h2>Giraffe</h2>

<p>Giraffes are the world's tallest mammals, thanks to their towering legs and long necks. A giraffe's legs alone are taller than many humans—about 6 feet . These long legs allow giraffes to run as fast as 35 miles an hour over short distances and cruise comfortably at 10 miles an hour over longer distances.</p>
<p><strong>Giraffes are the world's tallest mammals, thanks to their towering legs and long necks. A giraffe's legs alone are taller than many humans—about 6 feet . These long legs allow giraffes to run as fast as 35 miles an hour over short distances and cruise comfortably at 10 miles an hour over longer distances.</strong></p>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p><strong>Giraffes are the world's tallest mammals, thanks to their towering legs and long necks. A giraffe's legs alone are taller than many humans—about 6 feet . These long legs allow giraffes to run as fast as 35 miles an hour over short distances and cruise comfortably at 10 miles an hour over longer distances.</strong></p>
<p>Giraffes are the world's tallest mammals, thanks to their towering legs and long necks. A giraffe's legs alone are taller than many humans—about 6 feet . These long legs allow giraffes to run as fast as 35 miles an hour over short distances and cruise comfortably at 10 miles an hour over longer distances.</p>

The task is to make the font size of this paragraph larger, which we can do with the CSS property font-size. <strong> makes the font bold, which is not related to font size.


<time>2010-04-16</time>
<h4>Helping wild turtles in Seychelles</h4>
<h3>Helping wild turtles in Seychelles</h3>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h3>Helping wild turtles in Seychelles</h3>
<h4>Helping wild turtles in Seychelles</h4>

We can change this back to h4 as there's no task to change the heading level

<h4>Helping wild turtles in Seychelles</h4>
<h3>Helping wild turtles in Seychelles</h3>
<a>Find out More</a>
<br>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<br>

It's not common to use <br> anymore in frontend development. Instead, we would add space using CSS margins

<div class="education-container">
<h3>Learning resources for schools</h3>
<div class="container">
<h1>Learning resources for schools</h1>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h1>Learning resources for schools</h1>
<h3>Learning resources for schools</h3>

We should change this back to h3 as the tasks don't mention changing the heading level

<h1>Learning resources for schools</h1>
<p>Explore our activities, videos, and lesson plans to support a wide range of curriculum topics</p>
<button>Find them here</button>
<button id= "Find them here">Find them here</button>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<button id= "Find them here">Find them here</button>
<button id= "find-them-here">Find them here</button>

IDs and classes can't have spaces in them. Instead, normally we use dashes instead of spaces and make the text lowercase

<p>There are <strong>AMAZING</strong> benefits of becoming a member with Birmingham Zoo! Our members get special discounts in our shops, cafes, and unlimited entry</p>
<button>Learn More</button>
<div id="container">
<button id="Learn More">Learn More</button>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<button id="Learn More">Learn More</button>
<button id="learn-more">Learn More</button>

Same as my other comment

font-size: 175%;
font-size: 1rem;
color: rgb(209, 66, 22);
text-align: center;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These CSS properties change the style for all h2 elements on the page, but the tasks only want us to change the headings for specific sections. For example, the News heading should be centred, so we can use the selector news h2 instead to only select the h2 in the news section

}

button {
button:hover {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change this from button to button:hover, it means we only show these button styles when we hover on a button which is not what we want. Instead, we can create a new rule button:hover and leave this button { alone

@bonboh bonboh closed this Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants